Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update triplea_maps.yaml - v1.4 the_shogun #12622

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

TheDog-GH
Copy link
Contributor

Notes to Reviewer

@beelee1
Copy link
Contributor

beelee1 commented Jun 6, 2024

@TheDog-GH I will add it but I thought 2.6 doesn't use the yaml anymore. I haven't tried using it for any map updates. Maybe it auto does it when you update the repo ? Idk :) will have to check it out.

This will work for people on older versions though :)

@beelee1 beelee1 merged commit d74ba53 into triplea-game:master Jun 6, 2024
1 check passed
@beelee1
Copy link
Contributor

beelee1 commented Jun 7, 2024

@TheDog-GH yea as @asvitkine pointed out, only whole numbers work for the version change. I didn't look at it, just saw it was good to go. The only changes are usually just the number. Maybe the description.

Be good to have a catch for that though. I will look at the version number in the future before merging.

Last thing I want todo is create more work :)

@TheDog-GH
Copy link
Contributor Author

Thanks both!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants